Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 )

Change subject: First implementation of the LLSK audio SAPI
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h 
File include/osmocom/hnodeb/hnb_prim.h:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h@173 
PS2, Line 173: HNB_AUDIO_PRIM_CONN_ESTABLISH,
             : 	HNB_AUDIO_PRIM_CONN_RELEASE,
             : 	HNB_AUDIO_PRIM_CONN_DATA,
             : 	_HNB_AUDIO_PRIM_MAX
> I'm using CONN_DATA for payload forwarding which relates to an active connection or context, which w […]
ah, interesting.  Agreed.


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h@184 
PS2, Line 184: uint8_t remote_rtp_address_type;  /* enum u_addr_type */
             : 	union u_addr remote_rtp_addr;
> I preferred having an own format specified in the protocol, similar to what we have in PCUIF, rather […]
ok, fair enough - but then I would try to at least have one definition local to this header file, rather than repeating the same two members together in multiple *_param definitions.  The address type makes no sense without the address, and vice-versa. They only appear together -> struct.


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h@217 
PS2, Line 217: 	struct osmo_prim_hdr hdr;
> Not sure if it's really worth it, since anyway we can find the UE from the context_id, and then use  […]
ok, then let's do that.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d
Gerrit-Change-Number: 26502
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 18:09:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/c6c29bfd/attachment.htm>