This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 11: (4 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@34 PS11, Line 34: /*! \brief HNB_IUH primitives */ there could be some general comment with reference to X.210 and description who is provider and who is user in the terminology below, now that you didt the painful exercise... https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@146 PS11, Line 146: //struct hnb_iuh_conn_establish_req_param conn_establish_req; I'm confused. Almost all RUA connections are established from hnb to hnbgw (uplink direction, just like SCCP in Iu or A). As the SAP is "imagined" with the lower-layer as "user" and the uper layer as "provider", a conn_establish_req would be the very first thing that happens in any subscriber connection. However, the data type is commented out here? Also, later in the code hnb_iuh_conn_establish_req_param seems to be actually used? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@149 PS11, Line 149: / likweise, it is defined above, why not use it here? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c File src/osmo-hnodeb/llsk.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c@108 PS11, Line 108: HNB_PRIM_SAPI_IUH naming: Iuh is (RUA/RANAP + HNBAP + GTP + RTP). So what you mean here is the "Iuh control plane" or "Iuh signaling", or as HNBAP is handled by the upper layer, probably just the RUA part? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 07:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211212/ca01abba/attachment.htm>