<p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h">File include/osmocom/hnodeb/hnb_prim.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@34">Patch Set #11, Line 34:</a> <code style="font-family:monospace,monospace">/*! \brief HNB_IUH primitives */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">there could be some general comment with reference to X.210 and description who is provider and who is user in the terminology below, now that you didt the painful exercise...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@146">Patch Set #11, Line 146:</a> <code style="font-family:monospace,monospace">          //struct hnb_iuh_conn_establish_req_param conn_establish_req;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm confused.  Almost all RUA connections are established from hnb to hnbgw (uplink direction, just like SCCP in Iu or A).  As the SAP is "imagined" with the lower-layer as "user" and the uper layer as "provider", a conn_establish_req would be the very first thing that happens in any subscriber connection.  However, the data type is commented out here?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, later in the code hnb_iuh_conn_establish_req_param seems to be actually used?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h@149">Patch Set #11, Line 149:</a> <code style="font-family:monospace,monospace">            /</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">likweise, it is defined above, why not use it here?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c">File src/osmo-hnodeb/llsk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c@108">Patch Set #11, Line 108:</a> <code style="font-family:monospace,monospace">HNB_PRIM_SAPI_IUH</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">naming: Iuh is (RUA/RANAP + HNBAP + GTP + RTP).   So what you mean here is the "Iuh control plane" or "Iuh signaling", or as HNBAP is handled by the upper layer, probably just the RUA part?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357">change 26357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d </div>
<div style="display:none"> Gerrit-Change-Number: 26357 </div>
<div style="display:none"> Gerrit-PatchSet: 11 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 12 Dec 2021 07:40:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>