Change in libosmocore[master]: select: add member for human readable name to osmo_fd

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 )

Change subject: select: add member for human readable name to osmo_fd
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> I personally wouldn't add this field here, for several reasons:
> * It's breaking ABI in all our code base
> * We can have lots and lots of osmo_fd structures, we are adding more used space here for some specific case
> * Since it's a specific case, we have "void *data" for that. The name can be stored there (or as a field in the struct stored in *data).

I'm not so much worried about memory consumption.  Even in a large osmocom program with 1000 file descriptors, we're talking about 8kByte of RAM only.  Yes, of couse, I know about cache efficiency, but still I think this is not a concern.

In general, I think having named osmo_fd opens up other possibilities in terms of introspection via VTY.  So it's not a bad idea, IMHO.

Yes, it will break ABI.  That's the only really sad part about it.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479
Gerrit-Change-Number: 26453
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Dec 2021 15:28:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211209/65827699/attachment.htm>