Change in libosmocore[master]: select: add member for human readable name to osmo_fd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Dec 9 12:25:17 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 )

Change subject: select: add member for human readable name to osmo_fd
......................................................................


Patch Set 1: Code-Review-1

I personally wouldn't add this field here, for several reasons:
* It's breaking ABI in all our code base
* We can have lots and lots of osmo_fd structures, we are adding more used space here for some specific case
* Since it's a specific case, we have "void *data" for that. The name can be stored there (or as a field in the struct stored in *data).


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479
Gerrit-Change-Number: 26453
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Dec 2021 12:25:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211209/df06c693/attachment.htm>


More information about the gerrit-log mailing list