Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 7 07:39:08 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 )

Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc
......................................................................

BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc

Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33
Related: SYS#5047, OS#4728
---
M bsc/BSC_Tests.ttcn
1 file changed, 38 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 3aaab85..e7c4599 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2435,6 +2435,7 @@
 
 private function f_exp_sapi_n_reject(template (present) GsmSapi sapi := ?,
 				     template myBSSMAP_Cause cause := ?,
+				     template (present) BIT2 cc := ?,
 				     float T_val := 2.0)
 runs on test_CT {
 	var BSSAP_N_DATA_ind rx_di;
@@ -2451,6 +2452,15 @@
 			setverdict(fail, "Rx unexpected Cause IE: ",
 				   rx_cause, " vs expected ", tr_cause);
 		}
+
+		/* Who ever on the earth decided to define this field as two separate bits?!? */
+		var BIT2 rx_cc := rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c2
+				& rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c1;
+		if (not match(rx_cc, cc)) {
+			setverdict(fail, "Rx unexpected Control Channel type: ",
+				   rx_cc, " vs expected ", cc);
+		}
+
 		setverdict(pass);
 		}
 	[] BSSAP.receive(BSSAP_N_DATA_ind:?) -> value rx_di {
@@ -2544,6 +2554,33 @@
 	f_shutdown_helper();
 }
 
+/* Check DLCI CC (Control Channel type) bits in SAPI N Reject */
+testcase TC_rll_sapi_n_reject_dlci_cc() runs on test_CT {
+	var octetstring rnd_data := f_rnd_octstring(16);
+	var RSL_Message rx_rsl;
+	var DchanTuple dt;
+
+	f_init(1);
+
+	/* MS establishes a SAPI=0 link on DCCH */
+	dt := f_est_dchan(f_rnd_ra_cs(), 23, rnd_data);
+
+	/* MSC sends some data on (not yet established) SAPI=3 link */
+	BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSAP_DTAP(rnd_data, '03'O)));
+	/* BSC attempts to establish a SAPI=3 link on DCCH */
+	rx_rsl := f_exp_ipa_rx(0, tr_RSL_EST_REQ(dt.rsl_chan_nr, tr_RslLinkID_DCCH(3)));
+
+	/* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */
+	f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O));
+	f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B);
+
+	/* Clean up the connection */
+	BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
+	f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false);
+
+	f_shutdown_helper();
+}
+
 testcase TC_si_default() runs on test_CT {
 	f_init(0);
 	f_init_bts_and_check_sysinfo(0, expect_si := SystemInformationConfig_default);
@@ -10898,6 +10935,7 @@
 	execute( TC_rll_rel_ind_sapi_n_reject() );
 	execute( TC_rll_err_ind_sapi_n_reject() );
 	execute( TC_rll_timeout_sapi_n_reject() );
+	execute( TC_rll_sapi_n_reject_dlci_cc() );
 
 	/* Paging related tests */
 	execute( TC_paging_imsi_nochan() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33
Gerrit-Change-Number: 26457
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211207/d83efa65/attachment.htm>


More information about the gerrit-log mailing list