<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc<br><br>Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33<br>Related: SYS#5047, OS#4728<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 38 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 3aaab85..e7c4599 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -2435,6 +2435,7 @@</span><br><span> </span><br><span> private function f_exp_sapi_n_reject(template (present) GsmSapi sapi := ?,</span><br><span>                                      template myBSSMAP_Cause cause := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+                                   template (present) BIT2 cc := ?,</span><br><span>                                     float T_val := 2.0)</span><br><span> runs on test_CT {</span><br><span>        var BSSAP_N_DATA_ind rx_di;</span><br><span>@@ -2451,6 +2452,15 @@</span><br><span>                         setverdict(fail, "Rx unexpected Cause IE: ",</span><br><span>                                  rx_cause, " vs expected ", tr_cause);</span><br><span>           }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Who ever on the earth decided to define this field as two separate bits?!? */</span><br><span style="color: hsl(120, 100%, 40%);">+              var BIT2 rx_cc := rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c2</span><br><span style="color: hsl(120, 100%, 40%);">+                               & rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c1;</span><br><span style="color: hsl(120, 100%, 40%);">+          if (not match(rx_cc, cc)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   setverdict(fail, "Rx unexpected Control Channel type: ",</span><br><span style="color: hsl(120, 100%, 40%);">+                               rx_cc, " vs expected ", cc);</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          setverdict(pass);</span><br><span>            }</span><br><span>    [] BSSAP.receive(BSSAP_N_DATA_ind:?) -> value rx_di {</span><br><span>@@ -2544,6 +2554,33 @@</span><br><span>    f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Check DLCI CC (Control Channel type) bits in SAPI N Reject */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_rll_sapi_n_reject_dlci_cc() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+    var octetstring rnd_data := f_rnd_octstring(16);</span><br><span style="color: hsl(120, 100%, 40%);">+      var RSL_Message rx_rsl;</span><br><span style="color: hsl(120, 100%, 40%);">+       var DchanTuple dt;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  f_init(1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* MS establishes a SAPI=0 link on DCCH */</span><br><span style="color: hsl(120, 100%, 40%);">+    dt := f_est_dchan(f_rnd_ra_cs(), 23, rnd_data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* MSC sends some data on (not yet established) SAPI=3 link */</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSAP_DTAP(rnd_data, '03'O)));</span><br><span style="color: hsl(120, 100%, 40%);">+       /* BSC attempts to establish a SAPI=3 link on DCCH */</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_rsl := f_exp_ipa_rx(0, tr_RSL_EST_REQ(dt.rsl_chan_nr, tr_RslLinkID_DCCH(3)));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    /* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */</span><br><span style="color: hsl(120, 100%, 40%);">+        f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O));</span><br><span style="color: hsl(120, 100%, 40%);">+     f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Clean up the connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  f_shutdown_helper();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_si_default() runs on test_CT {</span><br><span>      f_init(0);</span><br><span>   f_init_bts_and_check_sysinfo(0, expect_si := SystemInformationConfig_default);</span><br><span>@@ -10898,6 +10935,7 @@</span><br><span>     execute( TC_rll_rel_ind_sapi_n_reject() );</span><br><span>   execute( TC_rll_err_ind_sapi_n_reject() );</span><br><span>   execute( TC_rll_timeout_sapi_n_reject() );</span><br><span style="color: hsl(120, 100%, 40%);">+    execute( TC_rll_sapi_n_reject_dlci_cc() );</span><br><span> </span><br><span>       /* Paging related tests */</span><br><span>   execute( TC_paging_imsi_nochan() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457">change 26457</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 </div>
<div style="display:none"> Gerrit-Change-Number: 26457 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>