Change in libosmocore[master]: gprs_ns2_sns: rework sns clean up

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Aug 31 18:42:16 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25145 )

Change subject: gprs_ns2_sns: rework sns clean up
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/25145/2/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/25145/2/src/gb/gprs_ns2_sns.c@2314 
PS2, Line 2314: 			/* keep the NSVC we need for SNS, but unconfigure it */
> Ther is this if (nsvc == gss->sns_nsvc) that guards this in the original version. […]
No it can't.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2639345fdf3cd300a934238d676c543065ceaa8b
Gerrit-Change-Number: 25145
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 31 Aug 2021 18:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/ab021072/attachment.htm>


More information about the gerrit-log mailing list