Change in libosmocore[master]: gprs_ns2_sns: rework sns clean up

dexter gerrit-no-reply at lists.osmocom.org
Thu Aug 12 09:28:13 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25145 )

Change subject: gprs_ns2_sns: rework sns clean up
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

To me this looks good. I have left two comments, probably everything is fine the way it is. I just wanted to make you aware of this.

https://gerrit.osmocom.org/c/libosmocore/+/25145/2/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/25145/2/src/gb/gprs_ns2_sns.c@2074 
PS2, Line 2074: 		gprs_ns2_free_nsvc(nsvc);
I have seen that the freeing is done differently in this patch: https://gerrit.osmocom.org/c/libosmocore/+/25147/2/src/gb/gprs_ns2_sns.c - Maybe doing this here in a similar way might be a good idea. However I am currently not aware which patch comes when in this patch. Maybe this is already changed. - I just wanted to make you aware of this. (There would also be a an llist_last to detect the end of the loop. http://git.osmocom.org/libosmocore/tree/include/osmocom/core/linuxlist.h)


https://gerrit.osmocom.org/c/libosmocore/+/25145/2/src/gb/gprs_ns2_sns.c@2314 
PS2, Line 2314: 			/* keep the NSVC we need for SNS, but unconfigure it */
Ther is this if (nsvc == gss->sns_nsvc) that guards this in the original version. I don't know if it can happen that gss->sns_nsvc is NULL or so.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2639345fdf3cd300a934238d676c543065ceaa8b
Gerrit-Change-Number: 25145
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 09:28:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210812/4e8e7f74/attachment.htm>


More information about the gerrit-log mailing list