This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25225 ) Change subject: vty: add "msc N bssmap reset" command ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bsc_vty.c@3328 PS1, Line 3328: DEFUN(msc_bssmap_reset, msc_bssmap_reset_cmd, > Shouldn't this have attributes like hidden or expert or whatever? I do not see any problem with this. If someone wants to use this to test something - fine. https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bssmap_reset.c File src/osmo-bsc/bssmap_reset.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bssmap_reset.c@248 PS1, Line 248: /* Immediately (1ms) kick off reset sending mechanism */ > why 1ms and not 0? Maybe because I did it the same way in bssmap_reset_alloc(). I don't remember what the reason for this was, probably just a random choice. I think it would work with 0ms just as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1975941b790d2b30d0904d41e456220cba26ecff Gerrit-Change-Number: 25225 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 24 Aug 2021 13:38:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210824/ed954da2/attachment.htm>