Change in osmo-bsc[master]: vty: add "msc N bssmap reset" command

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 24 09:04:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25225 )

Change subject: vty: add "msc N bssmap reset" command
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bsc_vty.c@3328 
PS1, Line 3328: DEFUN(msc_bssmap_reset, msc_bssmap_reset_cmd,
Shouldn't this have attributes like hidden or expert or whatever?


https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bssmap_reset.c 
File src/osmo-bsc/bssmap_reset.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25225/1/src/osmo-bsc/bssmap_reset.c@248 
PS1, Line 248: 	/* Immediately (1ms) kick off reset sending mechanism */
why 1ms and not 0?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25225
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1975941b790d2b30d0904d41e456220cba26ecff
Gerrit-Change-Number: 25225
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Aug 2021 09:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210824/32431f9c/attachment.htm>


More information about the gerrit-log mailing list