Change in osmo-msc[master]: vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 24 12:59:34 UTC 2021


Hello Jenkins Builder, neels, dexter, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-msc/+/25235

to look at the new patch set (#2).

Change subject: vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach
......................................................................

vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach

it was recently observed in a pcap trace with gsmtap_log that the
use_count contained a "vlr_sgs_imsi_detach" item despite no related
message was seen near by. Further investigation shows that there's an
unbalanced get+put code path, introduced by an early return added to fix
another issue.

related: SYS#5337
Fixes: 0803d88d9aa6ff36896fbde218018db3bea61dc7
Change-Id: I91ae956e50fca2f4d0e1d145d60ccb0ebfb409e9
---
M src/libvlr/vlr_sgs.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/25235/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25235
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91ae956e50fca2f4d0e1d145d60ccb0ebfb409e9
Gerrit-Change-Number: 25235
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210824/6d6c6d0a/attachment.htm>


More information about the gerrit-log mailing list