Change in osmo-msc[master]: vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 24 12:17:15 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/25235 )


Change subject: vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach
......................................................................

vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach

it was recently observed in a pcap trace with gsmtap_log that the
use_count contained a "vlr_sgs_imsi_detach" item despite no related
message was seen near by. Further investigation shows that there's an
unbalanced get+put code path, introduced by an early return added to fix
another issue.

Fixes: 0803d88d9aa6ff36896fbde218018db3bea61dc7
Change-Id: I91ae956e50fca2f4d0e1d145d60ccb0ebfb409e9
---
M src/libvlr/vlr_sgs.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/25235/1

diff --git a/src/libvlr/vlr_sgs.c b/src/libvlr/vlr_sgs.c
index 5659886..6421581 100644
--- a/src/libvlr/vlr_sgs.c
+++ b/src/libvlr/vlr_sgs.c
@@ -148,8 +148,10 @@
 	/* See also: 3GPP TS 29.118, 5.6.3 Procedures in the VLR: In case of
 	 * an implicit detach, we are supposed to check if the state of the
 	 * SGs-association, and only when it is not SGs-NULL, we may proceed. */
-	if (vsub->sgs_fsm->state == SGS_UE_ST_NULL && type == SGSAP_ID_NONEPS_T_IMPLICIT_UE_EPS_NONEPS)
+	if (vsub->sgs_fsm->state == SGS_UE_ST_NULL && type == SGSAP_ID_NONEPS_T_IMPLICIT_UE_EPS_NONEPS) {
+		vlr_subscr_put(vsub, __func__);
 		return;
+	}
 
 	switch (type) {
 	case SGSAP_ID_NONEPS_T_EXPLICIT_UE_NONEPS:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25235
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91ae956e50fca2f4d0e1d145d60ccb0ebfb409e9
Gerrit-Change-Number: 25235
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210824/55d0f95b/attachment.htm>


More information about the gerrit-log mailing list