Change in libosmocore[master]: stats: send real last value if no new values come

neels gerrit-no-reply at lists.osmocom.org
Fri Aug 20 11:17:20 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25206 )

Change subject: stats: send real last value if no new values come
......................................................................


Patch Set 4:

(2 comments)

it might be my lack of understanding the design principles of stat_item,
but i suspect a fundamental design problem introduced by the added bool:

https://gerrit.osmocom.org/c/libosmocore/+/25206/4/include/osmocom/core/stat_item.h 
File include/osmocom/core/stat_item.h:

https://gerrit.osmocom.org/c/libosmocore/+/25206/4/include/osmocom/core/stat_item.h@34 
PS4, Line 34: 	bool stats_last_sent_was_max;
how about the aspect of being stateless and allowing multiple consumers of stat items?


https://gerrit.osmocom.org/c/libosmocore/+/25206/4/src/stat_item.c 
File src/stat_item.c:

https://gerrit.osmocom.org/c/libosmocore/+/25206/4/src/stat_item.c@241 
PS4, Line 241:  * perspective and therefore be used by several backends simultaneously.
^ as explained here



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibeefd0e3d1dbe4be454ff05a21df4848b2abfabe
Gerrit-Change-Number: 25206
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Aug 2021 11:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210820/73abfad8/attachment.htm>


More information about the gerrit-log mailing list