<p style="white-space: pre-wrap; word-wrap: break-word;">it might be my lack of understanding the design principles of stat_item,<br>but i suspect a fundamental design problem introduced by the added bool:</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25206">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25206/4/include/osmocom/core/stat_item.h">File include/osmocom/core/stat_item.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/25206/4/include/osmocom/core/stat_item.h@34">Patch Set #4, Line 34:</a> <code style="font-family:monospace,monospace">       bool stats_last_sent_was_max;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">how about the aspect of being stateless and allowing multiple consumers of stat items?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25206/4/src/stat_item.c">File src/stat_item.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/25206/4/src/stat_item.c@241">Patch Set #4, Line 241:</a> <code style="font-family:monospace,monospace"> * perspective and therefore be used by several backends simultaneously.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">^ as explained here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25206">change 25206</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25206"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibeefd0e3d1dbe4be454ff05a21df4848b2abfabe </div>
<div style="display:none"> Gerrit-Change-Number: 25206 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 20 Aug 2021 11:17:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>