Change in libosmocore[master]: gprs_ns2: move sns_event into internal.h to direct emit events

dexter gerrit-no-reply at lists.osmocom.org
Wed Aug 18 15:15:45 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25144 )

Change subject: gprs_ns2: move sns_event into internal.h to direct emit events
......................................................................


Patch Set 2:

(1 comment)

unfortunately I do not really understand this. You want to have gprs_sns_event visible from other C-files, otherwise you wouln't put it in the header file. Maybe it helps if you would write in the commit message where gprs_sns_event is needed.

https://gerrit.osmocom.org/c/libosmocore/+/25144/2/src/gb/gprs_ns_sns.c 
File src/gb/gprs_ns_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/25144/2/src/gb/gprs_ns_sns.c@276 
PS2, Line 276: enum gprs_ns2_sns_event {
maybe it makes sense to do the renaming in a different patch - this would be easier/faster to review.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25144
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8e3fae4367c112b5a71bffb33c302d903855cddc
Gerrit-Change-Number: 25144
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 15:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210818/de8bf74a/attachment.htm>


More information about the gerrit-log mailing list