Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

dexter gerrit-no-reply at lists.osmocom.org
Mon Aug 16 15:48:40 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc 
File doc/manuals/chapters/mgwpool.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc@7 
PS4, Line 7: m
> mgw pooling is primarily intended to scale out to multiple hosts [with different IPs]. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc@7 
PS4, Line 7: multi-core CPUs.
> I would make different domains names for each mgw mandatory.
I have made this more clear in the NOTE. We could also enforce this in osmo-mgcp-client, but I do not think that this is an all to good idea. The confusion about this at for the users might be equal to the confusion caused by seemingly duplicate endpoint names.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/src/osmo-bsc/osmo_bsc_main.c 
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/src/osmo-bsc/osmo_bsc_main.c@871 
PS4, Line 871: static int bsc_mgw_setup()
> (void) if the function takes no arguments. () means any number of arguments.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Aug 2021 15:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210816/f8064bd0/attachment.htm>


More information about the gerrit-log mailing list