Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 15 17:46:30 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc 
File doc/manuals/chapters/mgwpool.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc@7 
PS4, Line 7: multi-core CPUs.
I would make different domains names for each mgw mandatory.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc@7 
PS4, Line 7: m
mgw pooling is primarily intended to scale out to multiple hosts [with different IPs].

I would rather say "this can help to scale out over multiple VMs or physical machnies.  Until osmo-mgw includes multithreading support, it may also be used ot scale-out to multiple cores on a single host."


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/doc/manuals/chapters/mgwpool.adoc@58 
PS4, Line 58:   mgw local-port 2429
might be useful to also specify a name [only with local significante to the user, displayed in VTY]


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/src/osmo-bsc/osmo_bsc_main.c 
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/4/src/osmo-bsc/osmo_bsc_main.c@871 
PS4, Line 871: static int bsc_mgw_setup()
(void) if the function takes no arguments. () means any number of arguments.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Sun, 15 Aug 2021 17:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210815/1a647930/attachment.htm>


More information about the gerrit-log mailing list