Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

dexter gerrit-no-reply at lists.osmocom.org
Fri Aug 6 12:53:02 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc 
File doc/manuals/chapters/running.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc@147 
PS1, Line 147: See also See also
> twice
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc@148 
PS1, Line 148: 
> In the other chapter and in the code you say that this is now the legacy method of configuration. […]
I have now renamed "legacy" into "single". After all it is not really a legacy (as in deprecated) configuration, even though one could configure a pool with only one member and have the same effect like old config would have. Both is valid.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@556 
PS1, Line 556: 		}
> this block is the same for both parts of the if ... […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Aug 2021 12:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/91174bec/attachment.htm>


More information about the gerrit-log mailing list