Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

dexter gerrit-no-reply at lists.osmocom.org
Fri Aug 6 09:59:54 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 2:

(11 comments)

Thanks for taking the time to review this.

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc 
File doc/manuals/chapters/mgwpool.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@9 
PS1, Line 9: placed
> placed,
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@26 
PS1, Line 26: l
> L
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@26 
PS1, Line 26:  
> ,
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@38 
PS1, Line 38: instances so
> instances, so
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@38 
PS1, Line 38: to
> To
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@39 
PS1, Line 39: interfere each
> interfere with each other
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@43 
PS1, Line 43: work
> works
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@53 
PS1, Line 53:   
> spaces at the end of the line, also below (gerrit highlights them)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@112 
PS1, Line 112: mgc
> mgw
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@113 
PS1, Line 113: restarting
> reconnecting? (that's the terminology used below, so I'd also use it here)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_vty.c@3386 
PS1, Line 3386: 
> (unintended?)
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Aug 2021 09:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/30dc92c3/attachment.htm>


More information about the gerrit-log mailing list