Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 20:24:17 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 )

Change subject: filesystem: add unit tests for encoder/decoder methods
......................................................................


Patch Set 1: Code-Review-1

> Patch Set 1:
> 
> (1 comment)
> 
> I am not familiar with the new pySim API, but it feels like you're re-inventing Python's unittest framework in this change.

Ideally the implementation should not be mixed with the unit tests, and there should be separate tests for separate API parts. This eliminates the need for custom and verbose logging, and helps to locate the problematic part faster. Also, unittest provides really nice API for tests: self.assertEqual, self.assertRaises, self.subTest, etc. which you don't seem to be using at all...


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2
Gerrit-Change-Number: 24012
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 20:24:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/e8a2aa72/attachment.htm>


More information about the gerrit-log mailing list