Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 20:17:52 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 )

Change subject: filesystem: add unit tests for encoder/decoder methods
......................................................................


Patch Set 1:

(1 comment)

I am not familiar with the new pySim API, but it feels like you're re-inventing Python's unittest framework in this change.

https://gerrit.osmocom.org/c/pysim/+/24012/1/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/24012/1/pySim/filesystem.py@383 
PS1, Line 383: 	file. To run this, simply define a _encode_decode_testvector[] testvector
Mix of tabs and spaces, please do s/\t/    /g.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2
Gerrit-Change-Number: 24012
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 20:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/bc3aa5ce/attachment.htm>


More information about the gerrit-log mailing list