This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24010 ) Change subject: utils: split string formatting from dec_addr_tlv ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@a302 PS2, Line 302: return (dec_addr_tlv(res), sw) Same here, let's use tuple/list expansion: return (*dec_addr_tlv(res), sw) https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@a361 PS2, Line 361: content = dec_addr_tlv(res) Same here. https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@32 PS2, Line 32: def format_addr(addr, addr_type='00'): Would be nice to always have type hints with the new API. https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/utils.py File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/utils.py@642 PS2, Line 642: return (None, None) Shouldn't this be considered an error? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id017b0786089adac4d6c5be688742eaa9699e529 Gerrit-Change-Number: 24010 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 20:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/14f03101/attachment.htm>