<p><a href="https://gerrit.osmocom.org/c/pysim/+/24010">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py">File pySim/cards.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@a302">Patch Set #2, Line 302:</a> <code style="font-family:monospace,monospace">                 return (dec_addr_tlv(res), sw)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, let's use tuple/list expansion:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  return (*dec_addr_tlv(res), sw)</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@a361">Patch Set #2, Line 361:</a> <code style="font-family:monospace,monospace">                              content = dec_addr_tlv(res)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/cards.py@32">Patch Set #2, Line 32:</a> <code style="font-family:monospace,monospace">def format_addr(addr, addr_type='00'):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would be nice to always have type hints with the new API.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/utils.py">File pySim/utils.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/24010/2/pySim/utils.py@642">Patch Set #2, Line 642:</a> <code style="font-family:monospace,monospace">        return (None, None)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't this be considered an error?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24010">change 24010</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24010"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id017b0786089adac4d6c5be688742eaa9699e529 </div>
<div style="display:none"> Gerrit-Change-Number: 24010 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Apr 2021 20:12:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>