This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808 ) Change subject: bsc: add TC_assignment_codec_fr_by_mode_modify ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn@789 PS3, Line 789: PDU_ML3_NW_MS > Makes more sense to use 'PDU_RRM_ChannelModeModify_NW_MS' here, because 'PDU_ML3_NW_MS' may technica […] keeping the entire PDU allows also examining upper layers of the message, if we would ever want to https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn@1246 PS3, Line 1246: var RSL_IE_Body chan_mode_ie; > This is a very imperative/C-style approach. […] i copied code i found elsewhere about RSL message handling. I'd much rather have a record / union of members instead of an IE list. Since we unfortunately do have an IE list, f_rsl_find_ie() is conceptually much cleaner than assuming IE ordering -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idf4efaed986de0bbd2b663313e837352cc139f0f Gerrit-Change-Number: 23808 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 19:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/1b5ffb4e/attachment.htm>