Change in osmo-ttcn3-hacks[master]: bsc: add TC_assignment_codec_fr_by_mode_modify

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 02:37:06 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808 )

Change subject: bsc: add TC_assignment_codec_fr_by_mode_modify
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn 
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn@789 
PS3, Line 789: PDU_ML3_NW_MS
Makes more sense to use 'PDU_RRM_ChannelModeModify_NW_MS' here, because 'PDU_ML3_NW_MS' may technically contain any other RR message, and it's not really handy to access its fields by full path, e.g. 'rr_channel_mode_modify_msg.msgs.rrm.channelModeModify.channelMode.mode' in your code below.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn@791 
PS3, Line 791: RSL_Message
Same here, I would rather store 'RSL_IE_List' instead of the full message. But I see that f_rsl_find_ie() wants exactly an 'RSL_Message' as the argument, so this one can be kept as-is.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808/3/bsc/MSC_ConnectionHandler.ttcn@1246 
PS3, Line 1246: 		var RSL_IE_Body chan_mode_ie;
This is a very imperative/C-style approach. Given that the ordering of IE in RSL messages is fixed and defined by 3GPP, I think you could just match the 'RSL_IE_List' against a template. If something does not math, TITAN will reflect this in the logs (TTCN_MATCHING).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idf4efaed986de0bbd2b663313e837352cc139f0f
Gerrit-Change-Number: 23808
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 02:37:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/e63c944d/attachment.htm>


More information about the gerrit-log mailing list