Change in pysim[master]: utils: specify paremeters of enc_plmn() as string

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 30 16:08:56 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23998 )

Change subject: utils: specify paremeters of enc_plmn() as string
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23998/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/23998/1/pySim/utils.py@a137 
PS1, Line 137: def enc_plmn(mcc, mnc):
I think it should/could even be Hexstr, as we use this in other places where we expect a string of hexadecimal nibbles.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I57cf8e2de357650aef2a06fbffc7615ccb2a45b4
Gerrit-Change-Number: 23998
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 30 Apr 2021 16:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/8f2026a9/attachment.htm>


More information about the gerrit-log mailing list