Change in pysim[master]: utils: specify paremeters of enc_plmn() as string

dexter gerrit-no-reply at lists.osmocom.org
Fri Apr 30 15:05:53 UTC 2021


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23998 )


Change subject: utils: specify paremeters of enc_plmn() as string
......................................................................

utils: specify paremeters of enc_plmn() as string

To prevent missunderstandings when using enc_plmn(), specify the input
parameters as string.

Change-Id: I57cf8e2de357650aef2a06fbffc7615ccb2a45b4
Related: OS#4963
---
M pySim/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/23998/1

diff --git a/pySim/utils.py b/pySim/utils.py
index a177c56..6034da4 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -134,7 +134,7 @@
 def enc_iccid(iccid:str) -> Hexstr:
 	return swap_nibbles(rpad(iccid, 20))
 
-def enc_plmn(mcc, mnc):
+def enc_plmn(mcc:str, mnc:str):
 	"""Converts integer MCC/MNC into 3 bytes for EF"""
 	if len(mnc) == 2:
 		mnc += "F" # pad to 3 digits if needed

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I57cf8e2de357650aef2a06fbffc7615ccb2a45b4
Gerrit-Change-Number: 23998
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/2855990d/attachment.htm>


More information about the gerrit-log mailing list