Change in osmo-bsc[master]: lchan_release(): do not release UNUSED lchan

neels gerrit-no-reply at lists.osmocom.org
Wed Apr 28 14:40:04 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23941 )


Change subject: lchan_release(): do not release UNUSED lchan
......................................................................

lchan_release(): do not release UNUSED lchan

I noticed that lchan_release() is generally called in varying error
situations, so it makes sense to generally skip the release procedure
when the lchan is already in the UNUSED state.

Change-Id: I6e9faf682d1668388d5470419110408a098b9900
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/23941/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index d58aac5..d2b7172 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1592,7 +1592,7 @@
 		   bool err, enum gsm48_rr_cause cause_rr,
 		   const struct osmo_plmn_id *last_eutran_plmn)
 {
-	if (!lchan || !lchan->fi)
+	if (!lchan || !lchan->fi || lchan->fi->state == LCHAN_ST_UNUSED)
 		return;
 
 	if (lchan->release.in_release_handler)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6e9faf682d1668388d5470419110408a098b9900
Gerrit-Change-Number: 23941
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/7fb90c9d/attachment-0001.htm>


More information about the gerrit-log mailing list