<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23941">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_release(): do not release UNUSED lchan<br><br>I noticed that lchan_release() is generally called in varying error<br>situations, so it makes sense to generally skip the release procedure<br>when the lchan is already in the UNUSED state.<br><br>Change-Id: I6e9faf682d1668388d5470419110408a098b9900<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/23941/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index d58aac5..d2b7172 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1592,7 +1592,7 @@</span><br><span>                bool err, enum gsm48_rr_cause cause_rr,</span><br><span>              const struct osmo_plmn_id *last_eutran_plmn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!lchan || !lchan->fi)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!lchan || !lchan->fi || lchan->fi->state == LCHAN_ST_UNUSED)</span><br><span>            return;</span><br><span> </span><br><span>  if (lchan->release.in_release_handler)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23941">change 23941</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23941"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6e9faf682d1668388d5470419110408a098b9900 </div>
<div style="display:none"> Gerrit-Change-Number: 23941 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>