Change in osmo-bts[master]: common/pcu_sock: comment out {dl, ul}_tbf_ext related warnings

fixeria gerrit-no-reply at lists.osmocom.org
Tue Apr 27 17:01:35 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/23918 )


Change subject: common/pcu_sock: comment out {dl,ul}_tbf_ext related warnings
......................................................................

common/pcu_sock: comment out {dl,ul}_tbf_ext related warnings

Unfortunately, endianness is a weak point in the design of PDUIF:
some fields are sent in the network byte order, some in the host
order.  Both {dl,ul}_tbf_ext do not seem to be used in osmo-pcu,
so we would probably need to investigate whether the coding is
correct later.  Do not spam compilation logs with that.

Change-Id: Iebf9961cffbd7aa20b263f7dc0016a44782dec60
---
M src/common/pcu_sock.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/18/23918/1

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 2d44e02..d55db81 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -318,9 +318,9 @@
 		info_ind->flags |= PCU_IF_FLAG_MCS8;
 	if (rlcc->cs_mask & (1 << GPRS_MCS9))
 		info_ind->flags |= PCU_IF_FLAG_MCS9;
-#warning	"isn't dl_tbf_ext wrong?: * 10 and no ntohs"
+	/* FIXME: isn't dl_tbf_ext wrong?: * 10 and no ntohs */
 	info_ind->dl_tbf_ext = rlcc->parameter[T_DL_TBF_EXT];
-#warning	"isn't ul_tbf_ext wrong?: * 10 and no ntohs"
+	/* FIXME: isn't ul_tbf_ext wrong?: * 10 and no ntohs */
 	info_ind->ul_tbf_ext = rlcc->parameter[T_UL_TBF_EXT];
 	info_ind->initial_cs = rlcc->initial_cs;
 	info_ind->initial_mcs = rlcc->initial_mcs;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23918
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iebf9961cffbd7aa20b263f7dc0016a44782dec60
Gerrit-Change-Number: 23918
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/0635ae3c/attachment.htm>


More information about the gerrit-log mailing list