<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23918">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common/pcu_sock: comment out {dl,ul}_tbf_ext related warnings<br><br>Unfortunately, endianness is a weak point in the design of PDUIF:<br>some fields are sent in the network byte order, some in the host<br>order.  Both {dl,ul}_tbf_ext do not seem to be used in osmo-pcu,<br>so we would probably need to investigate whether the coding is<br>correct later.  Do not spam compilation logs with that.<br><br>Change-Id: Iebf9961cffbd7aa20b263f7dc0016a44782dec60<br>---<br>M src/common/pcu_sock.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/18/23918/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 2d44e02..d55db81 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -318,9 +318,9 @@</span><br><span>             info_ind->flags |= PCU_IF_FLAG_MCS8;</span><br><span>      if (rlcc->cs_mask & (1 << GPRS_MCS9))</span><br><span>           info_ind->flags |= PCU_IF_FLAG_MCS9;</span><br><span style="color: hsl(0, 100%, 40%);">-#warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs"</span><br><span style="color: hsl(120, 100%, 40%);">+    /* FIXME: isn't dl_tbf_ext wrong?: * 10 and no ntohs */</span><br><span>  info_ind->dl_tbf_ext = rlcc->parameter[T_DL_TBF_EXT];</span><br><span style="color: hsl(0, 100%, 40%);">-#warning     "isn't ul_tbf_ext wrong?: * 10 and no ntohs"</span><br><span style="color: hsl(120, 100%, 40%);">+    /* FIXME: isn't ul_tbf_ext wrong?: * 10 and no ntohs */</span><br><span>  info_ind->ul_tbf_ext = rlcc->parameter[T_UL_TBF_EXT];</span><br><span>  info_ind->initial_cs = rlcc->initial_cs;</span><br><span>       info_ind->initial_mcs = rlcc->initial_mcs;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23918">change 23918</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23918"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iebf9961cffbd7aa20b263f7dc0016a44782dec60 </div>
<div style="display:none"> Gerrit-Change-Number: 23918 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>