Change in osmo-ttcn3-hacks[master]: pcu: Take into account TbfStartingTime

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 26 08:10:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877 )

Change subject: pcu: Take into account TbfStartingTime
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/PCU_Tests.ttcn@3738 
PS1, Line 3738: fn := ms.ul_tbf.start_time_fn
> Now we have a lot of code duplication with this optional argument. […]
No we can't, because that only needs to be used on the first UL block after Imm Ass on CCCH, so it depends totally on the test details.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dad0f3167ace8d4a763fed971db94f32faf6ced
Gerrit-Change-Number: 23877
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Apr 2021 08:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210426/0b2aa211/attachment.htm>


More information about the gerrit-log mailing list