Change in osmo-ttcn3-hacks[master]: pcu: Take into account TbfStartingTime

fixeria gerrit-no-reply at lists.osmocom.org
Sat Apr 24 01:15:02 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877 )

Change subject: pcu: Take into account TbfStartingTime
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/GPRS_Components.ttcn@100 
PS1, Line 100: uint32_t
GsmFrameNumber


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/GPRS_Components.ttcn@240 
PS1, Line 240: uint32_t
GsmFrameNumber


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/GPRS_Components.ttcn@285 
PS1, Line 285: TODO
What exactly is to be done here?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/1/pcu/PCU_Tests.ttcn@3738 
PS1, Line 3738: fn := ms.ul_tbf.start_time_fn
Now we have a lot of code duplication with this optional argument. Can't we just do this in f_ms_tx_ul_data_block(), so it would just take fn from 'ms.ul_tbf' itself?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dad0f3167ace8d4a763fed971db94f32faf6ced
Gerrit-Change-Number: 23877
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sat, 24 Apr 2021 01:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210424/3469a014/attachment.htm>


More information about the gerrit-log mailing list