Change in libosmocore[master]: sim: Remove 'printf' from library code

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 25 19:09:34 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23896 )


Change subject: sim: Remove 'printf' from library code
......................................................................

sim: Remove 'printf' from library code

Those were really meant as an early debugging aid and should not
have survived this long.

Change-Id: I4e9a80ced15686734d4485c232c5936f566cfd76
---
M src/sim/reader.c
M src/sim/reader_pcsc.c
2 files changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/23896/1

diff --git a/src/sim/reader.c b/src/sim/reader.c
index d5292ba..ae0aba9 100644
--- a/src/sim/reader.c
+++ b/src/sim/reader.c
@@ -123,7 +123,6 @@
 
 	/* save SW */
 	sw = msgb_apdu_sw(tmsg);
-	printf("sw = 0x%04x\n", sw);
 	msgb_apdu_sw(amsg) = sw;
 
 	switch (msgb_apdu_case(amsg)) {
diff --git a/src/sim/reader_pcsc.c b/src/sim/reader_pcsc.c
index 7d424b8..234a9a7 100644
--- a/src/sim/reader_pcsc.c
+++ b/src/sim/reader_pcsc.c
@@ -41,12 +41,9 @@
 if (rv != SCARD_S_SUCCESS) { \
 	fprintf(stderr, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \
 	goto end; \
-} else { \
-        printf(text ": OK\n\n"); \
 }
 
 
-
 struct pcsc_reader_state {
 	SCARDCONTEXT hContext;
 	SCARDHANDLE hCard;
@@ -166,13 +163,10 @@
 	DWORD rlen = msgb_tailroom(msg);
 	LONG rc;
 
-	printf("TX: %s\n", osmo_hexdump(msg->data, msg->len));
-
 	rc = SCardTransmit(st->hCard, st->pioSendPci, msg->data, msgb_length(msg),
 			   &st->pioRecvPci, msg->tail, &rlen);
 	PCSC_ERROR(rc, "SCardEndTransaction");
 
-	printf("RX: %s\n", osmo_hexdump(msg->tail, rlen));
 	msgb_put(msg, rlen);
 	msgb_apdu_le(msg) = rlen;
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e9a80ced15686734d4485c232c5936f566cfd76
Gerrit-Change-Number: 23896
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210425/f8015753/attachment.htm>


More information about the gerrit-log mailing list