<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23896">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sim: Remove 'printf' from library code<br><br>Those were really meant as an early debugging aid and should not<br>have survived this long.<br><br>Change-Id: I4e9a80ced15686734d4485c232c5936f566cfd76<br>---<br>M src/sim/reader.c<br>M src/sim/reader_pcsc.c<br>2 files changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/23896/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sim/reader.c b/src/sim/reader.c</span><br><span>index d5292ba..ae0aba9 100644</span><br><span>--- a/src/sim/reader.c</span><br><span>+++ b/src/sim/reader.c</span><br><span>@@ -123,7 +123,6 @@</span><br><span> </span><br><span>     /* save SW */</span><br><span>        sw = msgb_apdu_sw(tmsg);</span><br><span style="color: hsl(0, 100%, 40%);">-        printf("sw = 0x%04x\n", sw);</span><br><span>       msgb_apdu_sw(amsg) = sw;</span><br><span> </span><br><span>         switch (msgb_apdu_case(amsg)) {</span><br><span>diff --git a/src/sim/reader_pcsc.c b/src/sim/reader_pcsc.c</span><br><span>index 7d424b8..234a9a7 100644</span><br><span>--- a/src/sim/reader_pcsc.c</span><br><span>+++ b/src/sim/reader_pcsc.c</span><br><span>@@ -41,12 +41,9 @@</span><br><span> if (rv != SCARD_S_SUCCESS) { \</span><br><span>      fprintf(stderr, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \</span><br><span>    goto end; \</span><br><span style="color: hsl(0, 100%, 40%);">-} else { \</span><br><span style="color: hsl(0, 100%, 40%);">-        printf(text ": OK\n\n"); \</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct pcsc_reader_state {</span><br><span>         SCARDCONTEXT hContext;</span><br><span>       SCARDHANDLE hCard;</span><br><span>@@ -166,13 +163,10 @@</span><br><span>   DWORD rlen = msgb_tailroom(msg);</span><br><span>     LONG rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    printf("TX: %s\n", osmo_hexdump(msg->data, msg->len));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       rc = SCardTransmit(st->hCard, st->pioSendPci, msg->data, msgb_length(msg),</span><br><span>                     &st->pioRecvPci, msg->tail, &rlen);</span><br><span>         PCSC_ERROR(rc, "SCardEndTransaction");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    printf("RX: %s\n", osmo_hexdump(msg->tail, rlen));</span><br><span>      msgb_put(msg, rlen);</span><br><span>         msgb_apdu_le(msg) = rlen;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23896">change 23896</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23896"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4e9a80ced15686734d4485c232c5936f566cfd76 </div>
<div style="display:none"> Gerrit-Change-Number: 23896 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>