This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23865 ) Change subject: osmo-bts-trx: enlarge and share TRXD message buffer ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/23865/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/23865/1/src/osmo-bts-trx/trx_if.c@911 PS1, Line 911: const uint8_t *ptr = &trx_data_buf[0]; > It sounds more logical to move a 'pointer' forward while adding more stuff rather then moving a 'buf […] "buf" of course is a buffer pointer, which is already more explanatory than a "ptr". So yes, it makes more sense to mover the pointer in a "buffer" at will while filling it. Simply leave the old naming, then this patch turns 4 lines instead of 20. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I729451c8ecdc7ff2631beb423f15523db16b3ee3 Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 23 Apr 2021 18:02:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/2d88ae32/attachment.htm>