Change in osmo-bts[master]: osmo-bts-trx: enlarge and share TRXD message buffer

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 23 15:05:06 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23865 )

Change subject: osmo-bts-trx: enlarge and share TRXD message buffer
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23865/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23865/1/src/osmo-bts-trx/trx_if.c@911 
PS1, Line 911: 	const uint8_t *ptr = &trx_data_buf[0];
> Not sure what do we win with changing the name of the variable buf->ptr. […]
It sounds more logical to move a 'pointer' forward while adding more stuff rather then moving a 'buffer', which sounds odd to me. I can revert it back if you insist.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23865
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I729451c8ecdc7ff2631beb423f15523db16b3ee3
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Apr 2021 15:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/d730aa38/attachment.htm>


More information about the gerrit-log mailing list