Change in pysim[master]: utils: fix encoding of EF.MSISDN

dexter gerrit-no-reply at lists.osmocom.org
Fri Apr 23 13:53:09 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/pysim/+/23819

to look at the new patch set (#3).

Change subject: utils: fix encoding of EF.MSISDN
......................................................................

utils: fix encoding of EF.MSISDN

The encoding of EF.MSISDN is a bit unstrutured. The encoder function
does not return a valid result since it lacks the parameters
Capability/Configuration2 Record Identifier and Extension5 Record
Identifier, which are mandatory but can be set to 0xFF. Also the
encoder gets its input from pySim-shell, so it should have some
more input validation, especially when the user encodes an empty
string. The encoder and decoder function also do not have unit-tests.

Since the encoder now adds the missing two bytes by isself this does
not have to be done manually anymore, so cards.py needs to be
re-aligned.

For pySim-shell.py the encoder is used from ts_51_011.py. Unfortunately
it is used wrongly there. The optional Alpha Identifier is required
here as well.

Related: OS#4963
Change-Id: Iee5369b3e3ba7fa1155facc8fa824bc60e33b55b
---
M pySim/cards.py
M pySim/ts_51_011.py
M pySim/utils.py
M tests/test_utils.py
4 files changed, 46 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/23819/3
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iee5369b3e3ba7fa1155facc8fa824bc60e33b55b
Gerrit-Change-Number: 23819
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/852a3c34/attachment.htm>


More information about the gerrit-log mailing list