Change in pysim[master]: utils: fix encoding of EF.MSISDN

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 21 13:51:29 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23819 )

Change subject: utils: fix encoding of EF.MSISDN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23819/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/23819/1/pySim/utils.py@412 
PS1, Line 412: not msisdn or msisdn == ""
> It cannot be None (according to the type hint for 'msisdn'), so both statements are equivalent. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iee5369b3e3ba7fa1155facc8fa824bc60e33b55b
Gerrit-Change-Number: 23819
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 13:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/744021b0/attachment.htm>


More information about the gerrit-log mailing list