Change in osmo-ggsn[master]: gtp: Update teic_confirmed only on resp success

pespin gerrit-no-reply at lists.osmocom.org
Fri Apr 23 10:41:19 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/23850 )

Change subject: gtp: Update teic_confirmed only on resp success
......................................................................

gtp: Update teic_confirmed only on resp success

Change-Id: I54c54cbb51bfa5d1520855f448fa27511037b396
---
M gtp/gtp.c
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/gtp/gtp.c b/gtp/gtp.c
index 25eafdf..701aa36 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -1792,9 +1792,6 @@
 		return EOF;
 	}
 
-	/* Register that we have received a valid teic from GGSN */
-	pdp->teic_confirmed = 1;
-
 	/* Decode information elements */
 	if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) {
 		gsn->invalid++;
@@ -1894,6 +1891,8 @@
 					gsn->cb_conf(type, EOF, pdp, cbp);
 				return EOF;
 			}
+			/* Register that we have received a valid teic from GGSN */
+			pdp->teic_confirmed = 1;
 		}
 
 		if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) {
@@ -2345,9 +2344,6 @@
 		goto err_out;
 	}
 
-	/* Register that we have received a valid teic from GGSN */
-	pdp->teic_confirmed = 1;
-
 	/* Decode information elements */
 	if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) {
 		gsn->invalid++;
@@ -2393,6 +2389,8 @@
 			if (gtpie_gettv4(ie, GTPIE_TEI_C, 0, &pdp->teic_gn)) {
 				goto err_missing;
 			}
+			/* Register that we have received a valid teic from GGSN */
+			pdp->teic_confirmed = 1;
 		}
 
 		if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I54c54cbb51bfa5d1520855f448fa27511037b396
Gerrit-Change-Number: 23850
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/88d8611d/attachment.htm>


More information about the gerrit-log mailing list