<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23850">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp: Update teic_confirmed only on resp success<br><br>Change-Id: I54c54cbb51bfa5d1520855f448fa27511037b396<br>---<br>M gtp/gtp.c<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 25eafdf..701aa36 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -1792,9 +1792,6 @@</span><br><span>                 return EOF;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Register that we have received a valid teic from GGSN */</span><br><span style="color: hsl(0, 100%, 40%);">-     pdp->teic_confirmed = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  /* Decode information elements */</span><br><span>    if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) {</span><br><span>            gsn->invalid++;</span><br><span>@@ -1894,6 +1891,8 @@</span><br><span>                                   gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span>                                return EOF;</span><br><span>                  }</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* Register that we have received a valid teic from GGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+                   pdp->teic_confirmed = 1;</span><br><span>          }</span><br><span> </span><br><span>                if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) {</span><br><span>@@ -2345,9 +2344,6 @@</span><br><span>              goto err_out;</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Register that we have received a valid teic from GGSN */</span><br><span style="color: hsl(0, 100%, 40%);">-     pdp->teic_confirmed = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  /* Decode information elements */</span><br><span>    if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) {</span><br><span>            gsn->invalid++;</span><br><span>@@ -2393,6 +2389,8 @@</span><br><span>                   if (gtpie_gettv4(ie, GTPIE_TEI_C, 0, &pdp->teic_gn)) {</span><br><span>                                goto err_missing;</span><br><span>                    }</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* Register that we have received a valid teic from GGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+                   pdp->teic_confirmed = 1;</span><br><span>          }</span><br><span> </span><br><span>                if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23850">change 23850</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23850"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I54c54cbb51bfa5d1520855f448fa27511037b396 </div>
<div style="display:none"> Gerrit-Change-Number: 23850 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>