Change in osmo-bsc[master]: update neighbor ARFCNs on startup and config changes

neels gerrit-no-reply at lists.osmocom.org
Tue Apr 20 14:49:32 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23785 )

Change subject: update neighbor ARFCNs on startup and config changes
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/include/osmocom/bsc/bts.h@674 
PS1, Line 674: int gsm_net_set_system_infos();
> https://www.c-programming-simple-steps.com/what-is-void.html: […]
really, any number of any parameters??? C still does surprise me with some really crazy quirk every now and then. Maybe then we should do a sed to replace all / most parameter-less function declarations with "(void)" and have a check in the gerrit verfication job that prevents those in the future?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2222e029fc225152e124ed1e8887f1ffd4a107ef
Gerrit-Change-Number: 23785
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Apr 2021 14:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/2801e50a/attachment.htm>


More information about the gerrit-log mailing list