Change in osmo-bsc[master]: update neighbor ARFCNs on startup and config changes

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 20 08:23:21 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23785 )

Change subject: update neighbor ARFCNs on startup and config changes
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/include/osmocom/bsc/bts.h@674 
PS1, Line 674: int gsm_net_set_system_infos();
> we have a lot of function declarations without args that omit 'void' ... […]
https://www.c-programming-simple-steps.com/what-is-void.html:
"In C, if you don’t specify the parameters of a function, it can accept any number of parameters of any type.  The way to define a function, that does not accept parameters in C is to use the keyword void as the only element in the parameters list."

We already had issues in the past with not setting params as "void" which I had to fix, where wrong params or unused params end up being passed and the compiler doesn't warn, making code confusing. Having some functions not compling to it doesn't mean we should pay attention on new functions (and I'm sure I also introduce this kind of stuff myself from time to time).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2222e029fc225152e124ed1e8887f1ffd4a107ef
Gerrit-Change-Number: 23785
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Apr 2021 08:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/d7601e12/attachment.htm>


More information about the gerrit-log mailing list