Change in osmo-bts[master]: manuals: document new 'gsmtap-remote-host' command

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 16 14:42:30 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23770 )

Change subject: manuals: document new 'gsmtap-remote-host' command
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc@111 
PS1, Line 111: In order to activate this feature, you first need to make sure to specify
> I do not know if it is good to address the user directly. I would write: […]
In general, I don't see any problems with it. If there were 'Sie' in English, I would definitely use it ;) But this part was here before my patch, so I would not touch it here.


https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc@114 
PS1, Line 114: device will be sufficient:
> maybe "is sufficient" looks better.
Ack, but this is also part of the original text. Can be done in a separate patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23770
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f75fbac77a612493ce187cfac3c4ae203c81b23
Gerrit-Change-Number: 23770
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Apr 2021 14:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/74f43234/attachment.htm>


More information about the gerrit-log mailing list