Change in osmo-bts[master]: manuals: document new 'gsmtap-remote-host' command

dexter gerrit-no-reply at lists.osmocom.org
Fri Apr 16 10:31:45 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23770 )

Change subject: manuals: document new 'gsmtap-remote-host' command
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

looks ok to me. Just a few thoughts...

https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc@111 
PS1, Line 111: In order to activate this feature, you first need to make sure to specify
I do not know if it is good to address the user directly. I would write:

In order to activate this feature, it is necessary to make sure ...

or maybe "we":

In order to activate this feature, we first need to make sure to specify ...


https://gerrit.osmocom.org/c/osmo-bts/+/23770/1/doc/manuals/chapters/configuration.adoc@114 
PS1, Line 114: device will be sufficient:
maybe "is sufficient" looks better.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23770
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f75fbac77a612493ce187cfac3c4ae203c81b23
Gerrit-Change-Number: 23770
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Apr 2021 10:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/689e6b89/attachment.htm>


More information about the gerrit-log mailing list