Change in osmo-bts[master]: osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 16 05:49:08 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/23773 )


Change subject: osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands
......................................................................

osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands

* Remove way too verbose command description.  We have the manuals
  for explaining how things work, so let's avoid overloading commands
  with too many details.
* None of these commands apply immediately, correct the attributes.
** Remove meaningless call to l1if_provision_transceiver_trx().
* Make 'maxdlynb' hidden, so it only appears in the expert mode.
* One GMSK symbol actually corresponds to 550m.

Change-Id: I46839cf56bba2dcdc70303cd393e86d35aa2f3f5
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 13 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/23773/1

diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 8e701ea..9a205d5 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -235,18 +235,12 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN_ATTR(cfg_phyinst_maxdly, cfg_phyinst_maxdly_cmd,
-	   "osmotrx maxdly <0-31>",
-	   OSMOTRX_STR
-	   "Set the maximum acceptable delay of an Access Burst (in GSM symbols)."
-	   " Access Burst is the first burst a mobile transmits in order to establish"
-	   " a connection and it is used to estimate Timing Advance (TA) which is"
-	   " then applied to Normal Bursts to compensate for signal delay due to"
-	   " distance. So changing this setting effectively changes maximum range of"
-	   " the cell, because if we receive an Access Burst with a delay higher than"
-	   " this value, it will be ignored and connection is dropped.\n"
-	   "GSM symbols (approx. 1.1km per symbol)\n",
-	   CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_phyinst_maxdly, cfg_phyinst_maxdly_cmd,
+	      X(BTS_VTY_TRX_POWERCYCLE),
+	      "osmotrx maxdly <0-31>",
+	      OSMOTRX_STR
+	      "Set the maximum acceptable delay of an Access Burst\n"
+	      "Delay in GSM symbols (approx. 550m per symbol)\n")
 {
 	struct phy_instance *pinst = vty->index;
 	struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
@@ -254,25 +248,17 @@
 	l1h->config.maxdly = atoi(argv[0]);
 	l1h->config.maxdly_valid = 1;
 	l1h->config.maxdly_sent = false;
-	l1if_provision_transceiver_trx(l1h);
 
 	return CMD_SUCCESS;
 }
 
-DEFUN_ATTR(cfg_phyinst_maxdlynb, cfg_phyinst_maxdlynb_cmd,
-	   "osmotrx maxdlynb <0-31>",
-	   OSMOTRX_STR
-	   "Set the maximum acceptable delay of a Normal Burst (in GSM symbols)."
-	   " USE FOR TESTING ONLY, DON'T CHANGE IN PRODUCTION USE!"
-	   " During normal operation, Normal Bursts delay are controlled by a Timing"
-	   " Advance control loop and thus Normal Bursts arrive to a BTS with no more"
-	   " than a couple GSM symbols, which is already taken into account in osmo-trx."
-	   " So changing this setting will have no effect in production installations"
-	   " except increasing osmo-trx CPU load. This setting is only useful when"
-	   " testing with a transmitter which can't precisely synchronize to the BTS"
-	   " downlink signal, like e.g. R&S CMD57.\n"
-	   "GSM symbols (approx. 1.1km per symbol)\n",
-	   CMD_ATTR_IMMEDIATE)
+DEFUN_ATTR_USRATTR(cfg_phyinst_maxdlynb, cfg_phyinst_maxdlynb_cmd,
+		   CMD_ATTR_HIDDEN, /* expert mode command */
+		   X(BTS_VTY_TRX_POWERCYCLE),
+		   "osmotrx maxdlynb <0-31>",
+		   OSMOTRX_STR
+		   "Set the maximum acceptable delay of a Normal Burst\n"
+		   "Delay in GSM symbols (approx. 550m per symbol)\n")
 {
 	struct phy_instance *pinst = vty->index;
 	struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
@@ -280,7 +266,6 @@
 	l1h->config.maxdlynb = atoi(argv[0]);
 	l1h->config.maxdlynb_valid = 1;
 	l1h->config.maxdlynb_sent = false;
-	l1if_provision_transceiver_trx(l1h);
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23773
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I46839cf56bba2dcdc70303cd393e86d35aa2f3f5
Gerrit-Change-Number: 23773
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/e99ecbd9/attachment.htm>


More information about the gerrit-log mailing list