<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23773">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands<br><br>* Remove way too verbose command description. We have the manuals<br> for explaining how things work, so let's avoid overloading commands<br> with too many details.<br>* None of these commands apply immediately, correct the attributes.<br>** Remove meaningless call to l1if_provision_transceiver_trx().<br>* Make 'maxdlynb' hidden, so it only appears in the expert mode.<br>* One GMSK symbol actually corresponds to 550m.<br><br>Change-Id: I46839cf56bba2dcdc70303cd393e86d35aa2f3f5<br>---<br>M src/osmo-bts-trx/trx_vty.c<br>1 file changed, 13 insertions(+), 28 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/23773/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c</span><br><span>index 8e701ea..9a205d5 100644</span><br><span>--- a/src/osmo-bts-trx/trx_vty.c</span><br><span>+++ b/src/osmo-bts-trx/trx_vty.c</span><br><span>@@ -235,18 +235,12 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_phyinst_maxdly, cfg_phyinst_maxdly_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">- "osmotrx maxdly <0-31>",</span><br><span style="color: hsl(0, 100%, 40%);">- OSMOTRX_STR</span><br><span style="color: hsl(0, 100%, 40%);">- "Set the maximum acceptable delay of an Access Burst (in GSM symbols)."</span><br><span style="color: hsl(0, 100%, 40%);">- " Access Burst is the first burst a mobile transmits in order to establish"</span><br><span style="color: hsl(0, 100%, 40%);">- " a connection and it is used to estimate Timing Advance (TA) which is"</span><br><span style="color: hsl(0, 100%, 40%);">- " then applied to Normal Bursts to compensate for signal delay due to"</span><br><span style="color: hsl(0, 100%, 40%);">- " distance. So changing this setting effectively changes maximum range of"</span><br><span style="color: hsl(0, 100%, 40%);">- " the cell, because if we receive an Access Burst with a delay higher than"</span><br><span style="color: hsl(0, 100%, 40%);">- " this value, it will be ignored and connection is dropped.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "GSM symbols (approx. 1.1km per symbol)\n",</span><br><span style="color: hsl(0, 100%, 40%);">- CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_phyinst_maxdly, cfg_phyinst_maxdly_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ X(BTS_VTY_TRX_POWERCYCLE),</span><br><span style="color: hsl(120, 100%, 40%);">+ "osmotrx maxdly <0-31>",</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMOTRX_STR</span><br><span style="color: hsl(120, 100%, 40%);">+ "Set the maximum acceptable delay of an Access Burst\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Delay in GSM symbols (approx. 550m per symbol)\n")</span><br><span> {</span><br><span> struct phy_instance *pinst = vty->index;</span><br><span> struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span>@@ -254,25 +248,17 @@</span><br><span> l1h->config.maxdly = atoi(argv[0]);</span><br><span> l1h->config.maxdly_valid = 1;</span><br><span> l1h->config.maxdly_sent = false;</span><br><span style="color: hsl(0, 100%, 40%);">- l1if_provision_transceiver_trx(l1h);</span><br><span> </span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_phyinst_maxdlynb, cfg_phyinst_maxdlynb_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">- "osmotrx maxdlynb <0-31>",</span><br><span style="color: hsl(0, 100%, 40%);">- OSMOTRX_STR</span><br><span style="color: hsl(0, 100%, 40%);">- "Set the maximum acceptable delay of a Normal Burst (in GSM symbols)."</span><br><span style="color: hsl(0, 100%, 40%);">- " USE FOR TESTING ONLY, DON'T CHANGE IN PRODUCTION USE!"</span><br><span style="color: hsl(0, 100%, 40%);">- " During normal operation, Normal Bursts delay are controlled by a Timing"</span><br><span style="color: hsl(0, 100%, 40%);">- " Advance control loop and thus Normal Bursts arrive to a BTS with no more"</span><br><span style="color: hsl(0, 100%, 40%);">- " than a couple GSM symbols, which is already taken into account in osmo-trx."</span><br><span style="color: hsl(0, 100%, 40%);">- " So changing this setting will have no effect in production installations"</span><br><span style="color: hsl(0, 100%, 40%);">- " except increasing osmo-trx CPU load. This setting is only useful when"</span><br><span style="color: hsl(0, 100%, 40%);">- " testing with a transmitter which can't precisely synchronize to the BTS"</span><br><span style="color: hsl(0, 100%, 40%);">- " downlink signal, like e.g. R&S CMD57.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "GSM symbols (approx. 1.1km per symbol)\n",</span><br><span style="color: hsl(0, 100%, 40%);">- CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_ATTR_USRATTR(cfg_phyinst_maxdlynb, cfg_phyinst_maxdlynb_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ CMD_ATTR_HIDDEN, /* expert mode command */</span><br><span style="color: hsl(120, 100%, 40%);">+ X(BTS_VTY_TRX_POWERCYCLE),</span><br><span style="color: hsl(120, 100%, 40%);">+ "osmotrx maxdlynb <0-31>",</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMOTRX_STR</span><br><span style="color: hsl(120, 100%, 40%);">+ "Set the maximum acceptable delay of a Normal Burst\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Delay in GSM symbols (approx. 550m per symbol)\n")</span><br><span> {</span><br><span> struct phy_instance *pinst = vty->index;</span><br><span> struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span>@@ -280,7 +266,6 @@</span><br><span> l1h->config.maxdlynb = atoi(argv[0]);</span><br><span> l1h->config.maxdlynb_valid = 1;</span><br><span> l1h->config.maxdlynb_sent = false;</span><br><span style="color: hsl(0, 100%, 40%);">- l1if_provision_transceiver_trx(l1h);</span><br><span> </span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23773">change 23773</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23773"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I46839cf56bba2dcdc70303cd393e86d35aa2f3f5 </div>
<div style="display:none"> Gerrit-Change-Number: 23773 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>