Change in libosmocore[master]: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required

pespin gerrit-no-reply at lists.osmocom.org
Thu Apr 15 10:37:50 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23760 )

Change subject: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h@133 
PS2, Line 133: 	bool more_items; /*< always set this to false */
> https://gerrit.osmocom.org/c/libosmocore/+/9672 […]
That's indeed a good question, and tbh I don't fully understand why a lot of structs in this file have that "more_items" or how it is supposed to work from ABI point of view. I would welcome if whoever wrote that code initially can shed some light on this.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6280ce1abc283f1491bc6f391b2dd952df33a16b
Gerrit-Change-Number: 23760
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Apr 2021 10:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210415/7a266ca2/attachment.htm>


More information about the gerrit-log mailing list