Change in libosmocore[master]: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required

osmith gerrit-no-reply at lists.osmocom.org
Thu Apr 15 08:17:06 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23760 )

Change subject: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h@133 
PS2, Line 133: 	bool more_items; /*< always set this to false */
https://gerrit.osmocom.org/c/libosmocore/+/9672

> To existing structs gsm0808_old_bss_to_new_bss_info and
> gsm0808_handover_required, add a final 'more_items' flag that makes future
> extensions API and ABI compatible.

So shouldn't the extensions be after more_items, and have it set to true?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6280ce1abc283f1491bc6f391b2dd952df33a16b
Gerrit-Change-Number: 23760
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Apr 2021 08:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210415/e095402f/attachment.htm>


More information about the gerrit-log mailing list